publish entity updates (values only) #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements entity updates by publishing only the changed values.
- Added a new "value" field to both the GraphQL query and type definitions.
- Implemented update logic that serializes and compares current entity values before pushing updates.
- Removed an unnecessary ts-expect-error comment in the private spaces hook.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/hypergraph-react/src/prepare-publish.ts | Added "value" field and update logic for entity values. |
| apps/connect/src/hooks/use-private-spaces.ts | Removed ts-expect-error comment on appInfo usage. |
| const existingValue = data.entity.values.find((value) => value.propertyId === propertyId); | ||
|
|
||
| if (serializedValue !== existingValue?.value) { | ||
| values.push({ property: propertyId, value: serializedValue }); |
There was a problem hiding this comment.
The key 'property' used in the update object is inconsistent with the established schema which uses 'propertyId'. Update this to 'propertyId' to ensure consistency with the GraphQL query and type definitions.
Suggested change
| values.push({ property: propertyId, value: serializedValue }); | |
| values.push({ propertyId: propertyId, value: serializedValue }); |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.